Organizational Research By

Surprising Reserch Topic

Can't get a JSON object in response to an ajax request with wp_ajax


have a problem with WordPress and ajax.

This is my javascript part (I trimmed it a bit):

var posts = $.ajax({
    type: 'POST',
    url: ajaxurl,
    async: false,
    dataType: 'json',
    data: { action: 'myAjaxFunc' },
    done: function(response) {
        return response;
    }
}).responseText;

$.each(posts, function() {
    $('#someSelect').append( $('').text(this.name).val(this.id) );
});
My PHP code is as follows:

function myAjaxFunc() {

    $posts = get_posts( array(
        'posts_per_page'   => -1,
        'orderby'          => 'title',
        'order'            => 'ASC',
        'post_type'        => 'my-post-type',
        'post_status'      => array( 'publish', 'draft' )
    ) );

    $list = array();
    foreach ( $posts as $post ) {
        $list[] = array(
            'id'   => $post->ID,
            'name' => $post->post_title,
            'link' => get_permalink( $post->ID ),
        );
    }

    header("Content-type: application/json");
    echo json_encode( $list );
    die;
}
add_action( 'wp_ajax_nopriv_myAjaxFunc', 'myAjaxFunc' );
add_action( 'wp_ajax_myAjaxFunc', 'myAjaxFunc' );
The script gets the ajax response from admin-ajax. Unfortunately the console throws an error when it gets to the each statement in javascript... it says:

"Uncaught TypeError: Cannot use 'in' operator to search for '4' in Array".
If I do a console.log of my "posts" var I get a string 'Array'. No matter how I pass the $listvariable in PHP it will always return a string. The query returns posts elsewhere, so it's not empty. I tried without json_encode, with and without declaring header, using wp_send_json(), putting ob_clean() before echoing the array, putting the array into an array... But it always gets into ajax as a string Array and each cannot cycle through it.

This should be a very simple thing and I can't understand why it's not working. I don't have other javascript or php errors or warnings and everything else runs fine. I'm calling it a day and getting to sleep while posting this on stack :)

asked Apr 23, 2015 in jquery by rajesh
0 votes
111 views



Related Hot Questions

2 Answers

0 votes
Almost there with your PHP function. No need to set the header. (Edit: Also, assuming get_posts() is actually returning results.)

function myAjaxFunc() {

    $posts = get_posts( array(
        'posts_per_page'   => -1,
        'orderby'          => 'title',
        'order'            => 'ASC',
        'post_type'        => 'my-post-type',
        'post_status'      => array( 'publish', 'draft' )
    ) );

    $list = array();
    foreach ( $posts as $post ) {
        $list[] = array(
            'id'   => $post->ID,
            'name' => $post->post_title,
            'link' => get_permalink( $post->ID ),
        );
    }
    echo json_encode( $list );
    die;
}
add_action( 'wp_ajax_nopriv_myAjaxFunc', 'myAjaxFunc' );
add_action( 'wp_ajax_myAjaxFunc', 'myAjaxFunc' );
And your Javascript:

$.ajax({
    url: "/wp-admin/admin-ajax.php",
    type: "POST",
    data: "action=myAjaxFunc",
    success: function(results) {
        var posts = JSON.parse(results);
        console.log(results);
        $.each(posts, function() {
            $('#someSelect').append( $('').text(this.name).val(this.id) );
        });
    },
    error: function() {
        console.log('Cannot retrieve data.');
    }
});
answered Apr 23, 2015 by rajesh
0 votes
but eventually I realized that I should have replaced responseText with responseJSON method in my javascript code. In the example below I was storing the ajax response results in a variable. I didn't know there was a specific method to get response in JSON. In such way the object/array with get_posts() results is returned correctly and not as a string:

posts = $.ajax({
    type: 'GET',
    url: ajaxurl,
    async: false,
    dataType: 'json',
    data: { action : 'getHotelsList' },
    done: function(results) {
        // uhm, maybe I don't even need this?
        JSON.parse(results);
        return results;
    },
    fail: function( jqXHR, textStatus, errorThrown ) {
        console.log( 'Could not get posts, server response: ' + textStatus + ': ' + errorThrown );
    }
}).responseJSON; // <-- this instead of .responseText
Note to self but also general advice: if you can't fix something in the evening it's a sign you should go to bed, read a book, count stars. Answer will be found the next morning, the earlier the better :D
answered Apr 23, 2015 by rajesh

...